Conversation
mehanana
dismissed stale reviews from Rayna-Yu and nourshoreibah
via
05a66dd
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Looks like a couple tweaks needed on the merge conflict resolution. Other than that looks good!
Co-authored-by: Nour Shoreibah <168875317+nourshoreibah@users.noreply.github.com>
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
If you check the trace on GHA, it looks like it is failing because the package lock is out of sync with the package json. You could try reinstalling the packages to resolve this. Other than that LGTM (we'll have to reapprove after your changes)
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Wait where is the code for the route? is it already in main somehow?
tsudhakar87
left a comment
tsudhakar87
left a comment
There was a problem hiding this comment.
Looks good! I think you might just have to do another npm install to update package-lock
| "license": "MIT" | ||
| }, | ||
| "node_modules/@cspotcode/source-map-support": { | ||
| "version": "0.8.1", |
There was a problem hiding this comment.
Seems like CI is failing because of outdated package-lock
…/Code-4-Community/branch into #65-add-get-project-donors-route
tsudhakar87
left a comment
tsudhakar87
left a comment
There was a problem hiding this comment.
Yay! Looks good! If we want more to meet the 200 line diff requirement for today's grind sesh we could add tests for like 500s or something or add another unit test file (like in the reports lambda), but if we just want to get this merged for now that's good too
5 participants
ℹ️ Issue
Closes #65
📝 Description
Added GET /projects/{id}/donors endpoint so we can retreive all donors and their attributes for a project.
Briefly list the changes made to the code:
✔️ Verification
Verified through Swagger to make sure requests were working
Provide screenshots of any new components, styling changes, or pages.
🏕️ (Optional) Future Work / Notes
I had to add this line into the projects table of the database for one of my tests: ('Test Project', 100000, '2025-01-01', '2025-12-31', 'USD');